test(terraform): tidy up mysql terraform tests #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/183463641 The labels on this github issue will be updated when the story is started. |
blgm
approved these changes
Oct 5, 2022
pivotal-marcela-campo
changed the title
blgm
changed the title
pivotal-marcela-campo
changed the title
zucchinidev
reviewed
Oct 5, 2022
|
|
||
| Expect(AfterValuesForType(plan, "aws_db_instance")).To( | ||
| MatchKeys(IgnoreExtras, Keys{ | ||
| "parameter_group_name": Equal("default.mysql5.7"), |
There was a problem hiding this comment.
praise: marvellous! I love it!
zucchinidev
reviewed
Oct 5, 2022
| Expect(AfterValuesForType(plan, "aws_db_instance")).To( | ||
| MatchKeys(IgnoreExtras, Keys{ | ||
| "storage_type": Equal("io1"), | ||
| "iops": Equal(float64(3000)), |
There was a problem hiding this comment.
praise: fantastic! better than documentation and much faster to understand
zucchinidev
reviewed
Oct 5, 2022
| It("should pass the correct window", func() { | ||
| Expect(AfterValuesForType(plan, "aws_db_instance")).To( | ||
| MatchKeys(IgnoreExtras, Keys{ | ||
| "maintenance_window": Equal("mon:01:03-mon:02:04"), |
There was a problem hiding this comment.
thoughts: I wonder how maintenance_day has been converted to lowercase letters
zucchinidev
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
*[ ] Have you added Release Notes in the docs repositories?