feat: enable admin username and support cluster instance for aurora mysql #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cluster This is required to be able to import legacy instances from the legacy broker. Having to change the master password would result in instance recreation. [TPCF-26822](https://jira.eng.vmware.com/browse/TPCF-26822)
Legacy broker creates only one cluster with one cluster instance and names the cluster instance the same as the cluster name itself. Any attempt to set the cluster instance identifier to something else would trigger an instance recreation which we do not want.
zucchinidev
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Hi @FelisiaM, I think it looks good to me. I had doubts about the prohibit_update associated with the legacy_instance property, but I think I’m overengineering
zucchinidev
deleted the
feat_enable_admin_username_for_aurora_postgres
branch
FelisiaM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
make run-integration-testsandmake run-terraform-tests?