chore: remove Chi from test apps #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blgm
requested changes
Apr 30, 2024
| r.Put("/{schema}/{key}", handleSet(conn)) | ||
| r.Get("/{schema}/{key}", handleGet(conn)) | ||
| r := http.NewServeMux() | ||
| r.HandleFunc("GET /aliveness", aliveness) |
There was a problem hiding this comment.
The path has changed here. The aim of the aliveness endpoint is so that CloudFoundry knows that the app has started successfully, and I don't think changing the path work.
There was a problem hiding this comment.
You are right. I changed the path
blgm
approved these changes
Apr 30, 2024
blgm
force-pushed
the
chore_remove_chi_from_test_apps_187470327
branch
from
81e85fe
to
fa39f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187470327
Checklist:
make run-integration-testsandmake run-terraform-tests?