chore: add make target to run only modified tests #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185972417 The labels on this github issue will be updated when the story is started. |
Existing targets run all terraform or integrations tests for all services unless you manually focus some tests using FIt,FWhen,etc. This new target uses git to detect any modified uncommitted files and pass them to ginkgo through the `--focus-file`. This in effect causes Ginkgo to ignore any other tests and focus only on these. Warning: This target doesn't try to be smart and automatically run any tests related to some modified non-test files. The only thing this target does is run any new or modified uncommitted test files.
fnaranjo-vmw
force-pushed
the
chore-make-target-modified-tests
branch
from
4f3a11b
to
a8c84c3
Compare
zucchinidev
approved these changes
Sep 5, 2023
pivotal-marcela-campo
added a commit
that referenced
this pull request
Mar 25, 2024
csb 1.0.0 defaults to opentofu download url for tofu, hence there is no need to specify the url template anymore. [#187199931](https://www.pivotaltracker.com/story/show/187199931)
pivotal-marcela-campo
added a commit
that referenced
this pull request
Mar 25, 2024
csb 1.0.0 defaults to opentofu download url for tofu, hence there is no need to specify the url template anymore. [#187199931](https://www.pivotaltracker.com/story/show/187199931)
pivotal-marcela-campo
added a commit
that referenced
this pull request
Mar 25, 2024
csb 1.0.0 defaults to opentofu download url for tofu, hence there is no need to specify the url template anymore. [#187199931](https://www.pivotaltracker.com/story/show/187199931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing targets run all terraform or integrations tests for all services unless you use FIt, FDescribe, FWhen, etc to limit them.
This new Makefile uses git to detect which files were modified and pass them to ginkgo through the
--focus-file. This in effect causes Ginkgo to ignore any other tests files in the project.Warning: This target doesn't try to be smart and automatically run any tests related to some modified non-test file. The only thing this target does is run any test files modified in the current branch.
Checklist:
[ ] Have you added Release Notes in the docs repositories?[ ] Have you ranmake run-integration-testsandmake run-terraform-tests?[ ] Have you ran acceptance tests for the service under change?