Add nil guard to ProcessModel.run_action_user#4879
Open
jochenehret wants to merge 1 commit intomainfrom
Open
Conversation
jochenehret
force-pushed
the
prevent_app_nil_error
branch
from
a607fde to
0faaa76
Compare
* prevents exceptions "docker? delegated to app, but app is nil" when listing large number of processes on a live system
jochenehret
force-pushed
the
prevent_app_nil_error
branch
from
0faaa76 to
55b1c14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Nil guard prevents exceptions "docker? delegated to app, but app is nil" when listing large number of processes on a live system. The exception can happen if ProcessModel objects are processed while the associated app is being deleted.
An explanation of the use cases your change solves
Make sure that calling
/v3/processeson a live system does not result in sporadic "UnknownError"s.Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests