Open
Conversation
|
Releated issue: |
a01431e to
c0a216a
Compare
The error codes `60003` and `290013` appear twice. While many YAML parsers can cope with duplicate mapping keys, many parser will error out. External tools, like for example [go-cfclient's gen_error.go](https://github.com/cloudfoundry/go-cfclient/blob/main/tools/gen_error.go), cannot update to more recent major versions of their YAML parser library: ```shell yaml: unmarshal errors: line 221: mapping key "60003" already defined at line 216 line 1036: mapping key "290013" already defined at line 1026 panic: yaml: unmarshal errors: line 221: mapping key "60003" already defined at line 216 line 1036: mapping key "290013" already defined at line 1026 ``` Cloud Controller uses `psych` to parse the errors/*.yml files. Psych uses the latest occurence of a key. Therefore, the most recent duplicate key can be picked to stay in the errors files. ``` irb(main):001> require 'psych' => true irb(main):002> filepath = "errors/v2.yml" => "errors/v2.yml" irb(main):003* content = File.open(filepath) do |f| irb(main):004* Psych.safe_load(f, strict_integer: true) irb(main):005> end; nil => nil irb(main):006> content[60003] => {"name"=>"ServiceInstanceInvalid", "http_code"=>400, "message"=>"The service instance is invalid: %s"} irb(main):007> content[290013] => {"name"=>"SpaceRolesDeletionTimeout", "http_code"=>524, "message"=>"Deletion of roles for space %s timed out before all roles could be deleted"} ```
c0a216a to
3e650f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error codes
60003and290013appear twice. While many YAML parsers can cope with duplicate mapping keys, many parser will error out.External tools, like for example
go-cfclient's gen_error.go, cannot update to more recent major versions of their YAML parser library:
Cloud Controller uses
psychto parse the errors/*.yml files. Psych uses the latest occurence of a key. Therefore, the most recent duplicate key can be picked to stay in the errors files.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests