Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure DB Connection Pool Type #4012

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

svkrieger
Copy link
Contributor

  • A short explanation of the proposed change:

Configure DB connection pool type to threaded.

  • An explanation of the use cases your change solves

Sequel changed the default pool type, with which our extensions were not tested. With this PR we prevent that another pool type is used automatically.

  • Links to any other associated PRs

Unblocking the following dependency bump: #4006

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

Sequel changed the default connection pool type, which has not been tested with our extensions.
Therefore, configuring the pool type `:threaded`.
@philippthun philippthun merged commit 59c7328 into main Oct 7, 2024
8 checks passed
@philippthun philippthun deleted the configure-db-conn-pool-type branch October 7, 2024 14:01
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Oct 7, 2024
Changes in cloud_controller_ng:

- Configure DB Connection Pool Type
    PR: cloudfoundry/cloud_controller_ng#4012
    Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants