Pr/fix rakefile #3051
Closed
Pr/fix rakefile #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* we are quite certain that this code has never worked, despite being here since 2018. This commit d3a2cd1 introduced it, in order to set the npm "python" variable, but it ended up setting 2 variables, the "python" one as expected, and also another one called "bundle" to the value "install" (see what the "cmd" variable contains). * The initial author most likely meant to run both commands, that's why we added the && between the 2 commands, so that they both run. Co-authored-by: David Alvarado <alvaradoda@vmware.com> Co-authored-by: Bruce Ricard <bricard@vmware.com>
Co-authored-by: David Alvarado <alvaradoda@vmware.com> Co-authored-by: Bruce Ricard <bricard@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.