Prevent quota updates or assignment with finite log rates #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrmp
force-pushed
the
pr/182726901-log-rate-block-quota-updates
branch
3 times, most recently
from
2523601
to
cd83d9f
Compare
- If an existing deployment is upgraded to gain log rate limiting support then existing application processes will default to -1 (unlimited). - If an org or space quota is subsequently updated to include a finite log rate limit then processes in the affected orgs or spaces will be unable to restart without having their log rate limit changed. - Block org and space quota finite log rate limit updates until processes under the affected orgs or spaces have been updated with a finite log rate limit. Specify the names of the first two orgs or spaces and a total count in the error. - Block assignment of org or space quotas with finite log rate limits to orgs or spaces that contain processes with unlimited log rate limits. Co-authored-by: Carson Long <lcarson@vmware.com>
Block assignment of org or space quotas via the v2 endpoint if the quota has a finite log rate where the org or space contains processes that have unlimited log rate limits. Co-authored-by: Carson Long <lcarson@vmware.com>
acrmp
force-pushed
the
pr/182726901-log-rate-block-quota-updates
branch
from
cd83d9f
to
b57dfc8
Compare
MerricdeLauney
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Thanks for making the changes. Looks good to us!
cc: @jpalermo
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
…ry#2948) * Prevent org and space quota log rate limit changes - If an existing deployment is upgraded to gain log rate limiting support then existing application processes will default to -1 (unlimited). - If an org or space quota is subsequently updated to include a finite log rate limit then processes in the affected orgs or spaces will be unable to restart without having their log rate limit changed. - Block org and space quota finite log rate limit updates until processes under the affected orgs or spaces have been updated with a finite log rate limit. Specify the names of the first two orgs or spaces and a total count in the error. - Block assignment of org or space quotas with finite log rate limits to orgs or spaces that contain processes with unlimited log rate limits. * Prevent assignment of org and space quotas (v2) Block assignment of org or space quotas via the v2 endpoint if the quota has a finite log rate where the org or space contains processes that have unlimited log rate limits. Co-authored-by: Carson Long <lcarson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2900 to prevent updates to or assignment of org and space quotas with a finite log rate limit where they would apply to orgs or spaces that contain processes with unlimited log rate limits.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests