Ensuring we run record_route_transfer_owner only on a successful co…

…mmit.

Our tests include checks that ensure `record_route_transfer_owner` doesn't run on exceptions that result in a commit being rolled back.
Unfortunately the DB.transaction block does not bubble up `Sequel::RollBack` exceptions themselves--although it does bubble up all other types of exceptions that would result in a failed commit

Co-authored-by: Alex Rocha <alexr1@vmware.com>
Co-authored-by: Michael Oleske <moleske@pivotal.io>

app/actions/route_transfer_owner.rb

@@ -8,13 +8,15 @@ def transfer(route, target_space, user_audit_info)
 
         original_space = route.space
         Route.db.transaction do
+          Route.db.after_commit {
+            Repositories::RouteEventRepository.new.record_route_transfer_owner(
+              route, user_audit_info, original_space, target_space.guid)
+          }
           route.space = target_space
           route.remove_shared_space(target_space)
           route.add_shared_space(original_space)
           route.save
         end
-        Repositories::RouteEventRepository.new.record_route_transfer_owner(
-          route, user_audit_info, original_space, target_space.guid)
       end
     end
   end

spec/request/routes_spec.rb

@@ -3187,7 +3187,7 @@
       it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS
     end
 
-    it 'changes the route owner to the given space and logs an event' do
+    it 'changes the route owner to the given space and logs an event', isolation: :truncation do
       api_call.call(space_dev_headers)
 
       expect(last_response.status).to eq(200)

spec/unit/actions/route_transfer_owner_spec.rb

@@ -48,7 +48,7 @@ module VCAP::CloudController
         end
       end
 
-      it 'records a transfer event' do
+      it 'records a transfer event', isolation: :truncation do
         expect_any_instance_of(Repositories::RouteEventRepository).to receive(:record_route_transfer_owner).with(
           route, user_audit_info, original_owning_space, target_space.guid)