chore: refactor CredHub API to improve interface #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
blgm
commented
May 1, 2025
blgm
commented
- use "path" rather than "name" as this is the CredHub language
- don't leak app guid into API - use actor instead
cf-foundation-community-automation
bot
moved this to Inbox
in Service Management Working Group
blgm
force-pushed
the
chrft
branch
5 times, most recently
from
ca44318 to
13749c2
Compare
- use "path" rather than "name" for credentials as this matches the v2 CredHub - don't leak app guid into API - use actor instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.