Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Go 1.24 tool feature for Ginkgo #1188

Merged
merged 3 commits into from
Feb 13, 2025
Merged

chore: use Go 1.24 tool feature for Ginkgo #1188

merged 3 commits into from
Feb 13, 2025

Conversation

blgm
Copy link
Member

@blgm blgm commented Feb 12, 2025

No description provided.

@blgm blgm marked this pull request as draft February 12, 2025 12:36
@blgm blgm marked this pull request as ready for review February 13, 2025 11:11
Copy link
Contributor

@ifindlay-cci ifindlay-cci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blgm blgm merged commit bc682d5 into main Feb 13, 2025
8 checks passed
@blgm blgm deleted the gotool branch February 13, 2025 17:06
ifindlay-cci pushed a commit that referenced this pull request Feb 14, 2025
ifindlay-cci added a commit that referenced this pull request Feb 14, 2025
* Revert "chore: use Go 1.24 tool for staticcheck and goimports (#1191)"

This reverts commit 141c786.

* Revert "chore: use Go 1.24 tool feature for Ginkgo (#1188)"

This reverts commit bc682d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants