Skip to content

Check for chunk size before api call[v8] #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gururajsh merged 3 commits into from
Sep 11, 2025
Merged

Check for chunk size before api call[v8] #3574

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dbdd5a
Check for chunk size before api call
gururajsh Sep 9, 2025
d3609b9
Do not add to list if the current set is empty
gururajsh Sep 10, 2025
723c4f9
Merge branch 'v8' into resource-match-v8
gururajsh Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions actor/v7action/resource_match.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ func (actor Actor) ResourceMatch(resources []sharedaction.V3Resource) ([]shareda
)

for _, chunk := range resourceChunks {
newMatchedAPIResources, warnings, err := actor.CloudControllerClient.ResourceMatch(chunk)
allWarnings = append(allWarnings, warnings...)
if err != nil {
return nil, allWarnings, err
if len(chunk) > 0 {
newMatchedAPIResources, warnings, err := actor.CloudControllerClient.ResourceMatch(chunk)
allWarnings = append(allWarnings, warnings...)
if err != nil {
return nil, allWarnings, err
}
matchedAPIResources = append(matchedAPIResources, newMatchedAPIResources...)
}
matchedAPIResources = append(matchedAPIResources, newMatchedAPIResources...)
}

var matchedResources []sharedaction.V3Resource
Expand All @@ -51,8 +53,10 @@ func (Actor) chunkResources(resources []sharedaction.V3Resource) [][]ccv3.Resour
}

if len(currentSet) == constant.MaxNumberOfResourcesForMatching || index+1 == len(resources) {
chunkedResources = append(chunkedResources, currentSet)
currentSet = []ccv3.Resource{}
if len(currentSet) > 0 {
chunkedResources = append(chunkedResources, currentSet)
currentSet = []ccv3.Resource{}
}
}
}
return chunkedResources
Expand Down
Loading