Remove usage of CC's cloud_controller_container_networking_info and internal_route_vip_range
#332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `internal_route_vip_range`
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to remove the
cloud_controller_container_networking_infolink from CAPI release and the usage ofinternal_route_vip_rangein Cloud Controller.cf-networking release is still consuming the link, which is why we need to remove it from here first.
I built a dev release for cf-networking with the changes in this PR, as well as a dev release of capi including the below mentioned changes (+removed the link completely) and deployed it to a BBL environment. CATS were green.
Please check whether it can be removed from your POV. Also please check whether I got all references.
Here is the initial issue: cloudfoundry/cloud_controller_ng#3712
And those PRs will remove it from CAPI release and CC:
cloudfoundry/cloud_controller_ng#3761
cloudfoundry/capi-release#419
Backward Compatibility
Breaking Change? Yes/No
I suppose no if it is dead code.