Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply disable-v2-api ops file to all bbl envs used in cf-deployment validation #1211

Conversation

WeiQuan0605
Copy link
Contributor

Please take a moment to review the questions before submitting the PR

🚫 We only accept PRs to develop branch. If this is an exception, please specify why 🚫

WHAT is this change about?

This change will disable the v2 api for all bbl environments used in the cf deployment pipeline.

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

Alana want to safely remove CF API v2 from CAPI and cf-deployment.

Please provide any contextual information.

Core of Phase 1 of RFC-00032: CF API v2 End of Life

Has a cf-deployment including this change passed cf-acceptance-tests?

  • YES
  • NO

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

Types of breaking changes:

  1. causes app or operator downtime
  2. increases VM footprint of cf-deployment - e.g. new jobs, new add ons, increases # of instances etc.
  3. modifies, deletes or moves the name of a job or instance group in the main manifest
  4. modifies the name or deletes a property of a job or instance group in the main manifest
  5. changes the name of credentials in the main manifest
  6. requires out-of-band manual intervention on the part of the operator
  7. modifies the ops-file path, changes the type, changes the values or removes ops-files from the following folders
    • ./operations/ or ./operations/experimental
    • ./addons
    • ./backup-and-restore/

If you're promoting an experimental Ops-file (or removing one), Please follow the Ops-file workflows.

Ops files changes in the following folders are considered as NON BREAKING CHANGES
./community, ./example-vars-files, ./test

How should this change be described in cf-deployment release notes?

Something brief that conveys the change and is written with the persona (Alana, Cody...) in mind. See previous release notes for examples.

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

Please specify either bosh cli or cf cli commands for our team (and cf operators) to verify the changes.

Few examples

  1. For a PR with a new job in the manifest, bosh instances can verify the job is running after upgrade. You can provide additional commands to verify the job is running as specified.
  2. For a PR with new variables, bosh variables | grep <var-name> command can verify the variable exists. This is the simplest varification but you can also provide additional commands to test that the variable holds the desired value.

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

@jochenehret jochenehret requested review from a team November 12, 2024 10:27
Copy link
Contributor

@dimivel dimivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochenehret
Copy link
Contributor

Updated pipeline: https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/cf-deployment
The bbr jobs are green, that was the biggest unknown. Merging PR now.

@jochenehret jochenehret merged commit b13167e into cloudfoundry:develop Nov 15, 2024
3 checks passed
@WeiQuan0605 WeiQuan0605 deleted the Disable-v2-api-to-all-bbl-envs branch November 18, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants