Draft
Conversation
* prepackage local copy of Bundler gem so we can install it during packaging
5 tasks
Member
Author
|
✅ fog-local passed units on 3.3: |
Member
Author
|
✅ fog-azure-rm units passed on 3.3: I had to fix the tests for 3.2 while I was at it: fog/fog-azure-rm#447 |
Member
Author
|
✅ fog-aws units passed on 3.3: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In light of the impending Ruby 3.2 EOL (2026-03-31) we need to upgrade Ruby.
Upgrading to Ruby 3.3 is complicated by this Bundler bug: ruby/rubygems#8217, and this PR gets around this bug by using
gem fetch bundler -v GEMFILE_LOCK_VERSIONin prepackaging and installing from the local bundler gem copy during packaging.Every jobs which uses the CCNG job will check if the right bundler gem version is installed, and if not, install from the local copy.
(another potential solution is packaging
giton the VMs)I'm putting forth this solution as opposed to upgrading to Ruby 3.4 directly (which would skip the broken Bundler version), as Ruby 3.4 will require more syntax changes and we'd be more at risk of encountering gems that are incompatible with 3.4, notably the unmaintained Fog gems. Compare the Ruby 3.3 changeset to the old Ruby 3.4 changeset from a year ago.
Tasks before this is safe to merge:
Figure out how to avoid Bundler bug: Bundler 2.5.17 breaks bundling vendored gems from git, when git is not installed
during bundle install --localruby/rubygems#8217Run units on various fog gems on Ruby 3.3 (and make PRs if necessary)
CATs/BARAs on Blobstores for Fog coverage
Related Issues
cloudfoundry/cloud_controller_ng#4682