Conversation
aramprice
force-pushed
the
add-ruby-workflow
branch
from
9761448 to
084e221
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
- ruby 2.6: add ignore for Style/ArgumentsForwarding
aramprice
force-pushed
the
add-ruby-workflow
branch
from
0371ded to
3c2adbf
Compare
aramprice
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
aramprice
requested review from
a team,
KauzClay and
julian-hj
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive Ruby testing infrastructure to validate embedded Ruby code execution across multiple Ruby versions (2.6 through head) and operating systems. The workflow addresses a known compatibility issue where Ruby versions > 3.4 no longer include the ostruct gem in the default gemset.
Key Changes:
- Added GitHub Actions workflow to test Ruby code against versions 2.6 through head
- Created RSpec test suite with specs for ERBRenderer initialization and rendering
- Modernized erb_renderer.rb with style improvements and safer Ruby patterns
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ruby.yml | Defines CI workflow to run specs across Ruby 2.6-head and ubuntu/macos |
| templatescompiler/erbrenderer/Gemfile | Adds test dependencies (rspec, standardrb, rake) |
| templatescompiler/erbrenderer/Rakefile | Configures rake tasks for running specs and linting |
| templatescompiler/erbrenderer/.gitignore | Excludes Gemfile.lock from version control |
| templatescompiler/erbrenderer/spec/spec_helper.rb | Sets up RSpec test environment and load paths |
| templatescompiler/erbrenderer/spec/erb_renderer_spec.rb | Adds test coverage for ERBRenderer initialization and template rendering |
| templatescompiler/erbrenderer/erb_renderer.rb | Applies style improvements, modernizes Ruby patterns (alias_method, File.write, JSON.load_file) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aramprice
force-pushed
the
add-ruby-workflow
branch
from
3c2adbf to
816b026
Compare
aramprice
changed the title
rkoster
requested changes
Dec 29, 2025
github-project-automation
bot
moved this from Pending Review | Discussion
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
The `.load_file` was added around 2020 and the JSON gem may not be updated on some systems.
aramprice
force-pushed
the
add-ruby-workflow
branch
from
816b026 to
b387a21
Compare
beyhan
approved these changes
Jan 8, 2026
rkoster
approved these changes
Jan 8, 2026
github-project-automation
bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
rubionic
added a commit
to rubionic/bosh-cli
that referenced
this pull request
Jan 15, 2026
Add comprehensive Ruby testing infrastructure to verify PropertyStruct compatibility across Ruby versions 2.6 through head. Following the pattern from PR cloudfoundry#707, this adds: - GitHub Actions workflow testing across Ruby 2.6-3.4 and head - RSpec test suite for PropertyStruct - Tests for dynamic attribute access, nested structures, and arrays - Tests for Ruby standard library method pass-through - Tests for OpenStruct API compatibility The Ruby matrix ensures PropertyStruct works correctly across all supported Ruby versions, particularly validating Ruby 3.5+ compatibility where ostruct is being removed. Related to cloudfoundry#708
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow to test the execution of the embedded ruby code against Rubies >= 2.6
The spec will not pass against Ruby > 3.4 because the
ostructgem required by the code is no longer part of the default gemset.NOTE: the
bosh-clicurrently relies on whicheverrubyexecutable is found in its$PATHwhen invoked, and does not have the capacity to install gems.