Skip to content

add integration tests for finalize release using bosh-cli#675

Merged
aramprice merged 2 commits intomainfrom
port-cli-only-director-integration-specs
Dec 12, 2024
Merged

add integration tests for finalize release using bosh-cli#675
aramprice merged 2 commits intomainfrom
port-cli-only-director-integration-specs

Conversation

@nader-ziada
Copy link
Contributor

These test cases used to be part of the Bosh Director repo when the CLI was included there. But now that CLI v2 is separate and finalize doesn't use director, it's better to move them here.

@nader-ziada
Copy link
Contributor Author

creating as draft as I'm still adding test cases for the create-release test

These test cases used to be part of the Bosh Director repo when the CLI was included there. But now that CLI v2 is separate and finalize doesn't use director, it's better to move them here.
@nader-ziada nader-ziada force-pushed the port-cli-only-director-integration-specs branch from 6134fbd to cf642d8 Compare December 9, 2024 20:57
These tests were originally part of the bosh repo when the CLI was included there.
However, since these tests don't need to interact with a director, better to move themn
closer to the code

Signed-off-by: Rajath Agasthya <rajath.agasthya@broadcom.com>
@nader-ziada nader-ziada force-pushed the port-cli-only-director-integration-specs branch from 70497cc to a5d1618 Compare December 12, 2024 14:12
@nader-ziada nader-ziada marked this pull request as ready for review December 12, 2024 14:12
@nader-ziada
Copy link
Contributor Author

ready for review

@jpalermo
Copy link

@nader-ziada could you link to the commits where this was removed from the director?

@jpalermo jpalermo requested review from a team and xtreme-nitin-ravindran and removed request for a team December 12, 2024 15:46
@aramprice
Copy link
Member

aramprice commented Dec 12, 2024

@aramprice
Copy link
Member

aramprice commented Dec 12, 2024

@nader-ziada / @rajathagasthya can these two commits be squashed, or should is there context in having both of them? Never mind, moving too fast.

@aramprice aramprice merged commit 25fb89f into main Dec 12, 2024
8 checks passed
@aramprice aramprice deleted the port-cli-only-director-integration-specs branch December 12, 2024 19:40
selzoc added a commit to cloudfoundry/bosh that referenced this pull request Dec 12, 2024
These test were moved to the cli integration test suite in
cloudfoundry/bosh-cli#675

Co-authored-by: Chris Selzo <chris.selzo@broadcom.com>
@selzoc
Copy link
Member

selzoc commented Dec 12, 2024

Here's the existing tests we hope to delete after this is merged: https://github.com/cloudfoundry/bosh/blob/main/src/spec/integration/release/create_release_spec.rb https://github.com/cloudfoundry/bosh/blob/main/src/spec/integration/release/finalize_release_spec.rb

These have been removed as of cloudfoundry/bosh@ad4b9c5

aramprice added a commit to cloudfoundry/bosh that referenced this pull request Dec 12, 2024
These specs exercise CLI local capabilities and don't make sense in the
bosh repo (historicall the bosh cli was _another_ ruby gem). These have
been ported to the `bosh-cli` repo via
- cloudfoundry/bosh-cli#675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants