Conversation
aramprice
reviewed
Oct 16, 2024
| import ( | ||
| "archive/tar" | ||
| "compress/gzip" | ||
| gzip "github.com/klauspost/pgzip" |
Member
There was a problem hiding this comment.
same as in bosh-utils: this import alias only hides info, would recommend removing it.
also putting non-standard-lib imports here will make the linter 😡
aramprice
approved these changes
Oct 16, 2024
Contributor
Author
|
Blocked on bosh-utils ci being broken |
rkoster
force-pushed
the
pgzip
branch
2 times, most recently
from
ab0eeea to
700ca89
Compare
jpalermo
approved these changes
Nov 21, 2024
selzoc
added a commit
that referenced
this pull request
Dec 16, 2024
This is basically a revert of #669. We found that the bosh cli with the pgzip code produces releases that cannot be compiled by the bosh agent. In addition, there were many many edge cases that we found we had to fix and/or paper over that have been solved in the tar executable over the past decades. Maybe in the future we can give this another go, as the performance improvements would be welcome. Signed-off-by: Ming Xiao <ming.xiao@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is blocked by: cloudfoundry/bosh-utils#98