Switch to golangci-lint meta-lint tool #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unused code in `jobsupervisor/`
- address shellcheck issues - create generic `bin/lint` and `bin/format` helpers (not named after specific formatter / linter tools) - add TODO's around making tests more modular
aramprice
force-pushed
the
wip/switch-to-golangci-lint
branch
from
599a220
to
9f03a0d
Compare
aramprice
changed the title
cunnie
reviewed
Mar 28, 2022
| } | ||
| } | ||
| return hints | ||
| } |
There was a problem hiding this comment.
I assume pruneNil is not called anywhere. Nice job cleaning up!
There was a problem hiding this comment.
Yup, quite a bit of dead code. Mostly stuff that was replaced by sigar but never removed.
cunnie
approved these changes
Mar 29, 2022
camilalonart
approved these changes
Mar 29, 2022
| @@ -275,7 +275,7 @@ var _ = Describe("cascadingBlobstore", func() { | |||
| blobManagers = append(blobManagers, blobManager) | |||
| } | |||
|
|
|||
| index := rand.Intn(10) | |||
| index := rand.Intn(10) //nolint:gosec | |||
There was a problem hiding this comment.
Why generating a random number could provoke a security problem?
| @@ -60,7 +60,3 @@ func (r *StartManager) persistentBootoncePath() string { | |||
| func (r *StartManager) tmpfsBootoncePath() string { | |||
| return filepath.Join(r.dirProvider.CanRestartDir(), BootonceFileName) | |||
| } | |||
|
|
|||
| func touch(fs boshsys.FileSystem, path string) error { | |||
There was a problem hiding this comment.
Is this function never used?
Justin-W
added a commit
to calculi-corp/bosh-agent
that referenced
this pull request
Mar 31, 2022
…vior. This fixes an inconsistency between output vs behavior that was introduced by edfed12 as part of cloudfoundry#272.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bin/test-unit runs
go run golang.org/x/lint/golintvia bin/golint.The
golang.org/x/lint/golintcommand has been deprecated and frozen since 2020.This commit switches to the meta-lint tool https://golangci-lint.run/
Additional Changes
bin/golangci-lintgoimportsas recommended bygolangci-lintgoimportsaddsimportformatting and is otherwise the same asgo fmt