This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
Rename roles to instance groups #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 2, 2018 10:43
* rename `model.Roles` to `InstanceGroups` * rename `model.RoleJob` to `JobReference` * rename `roles:` key to `instance_groups:` in role manifest * rename some related functions, i.e. `IsColocatedContainerRole` * rename local variables, change comments and error messages * change tests to tag the instance group with the name "some-group" instead of "role"
|
This should trigger a major version change |
viovanov
approved these changes
Aug 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the first big rename from issue #370 to make the role manifest compatible with BOSH deployment manifests.
model.RolestoInstanceGroupsmodel.RoleJobtoJobReferenceroles:key toinstance_groups:in role manifestIsColocatedContainerRole