Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service broker name and guid #234

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

Useurmind
Copy link
Contributor

Hello,

in some cases it can become necessary to filter services not only by name/id and space but also by service broker guid. This is necessary if two brokers offer a service with the same name.

I added a service_broker_guid which is an optional input field used for filtering when set.
And a service_broker_name which is a computed output field.

I currently see no more possibilities with the v2 client in use.

Kind Regards
Jochen

@ArthurHlt
Copy link
Member

thanks for the PR
Looks fine to me, just you are targetting the wrong branch (master instead of dev).
Could you add doc on file: https://github.com/cloudfoundry-community/terraform-provider-cf/blob/master/docs/data-sources/service.md

@Useurmind Useurmind changed the base branch from master to dev February 11, 2020 04:33
@Useurmind
Copy link
Contributor Author

I changed the branch and extended the existing doc file with the new fields.

@ArthurHlt ArthurHlt merged commit f8c8f08 into cloudfoundry-community:dev Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants