Fix including all package bin directories#49
Open
sharms wants to merge 1 commit intocloudfoundry-community:masterfrom
Open
Fix including all package bin directories#49sharms wants to merge 1 commit intocloudfoundry-community:masterfrom
sharms wants to merge 1 commit intocloudfoundry-community:masterfrom
Conversation
sharms
commented
Jun 3, 2016
sharms
commented
- Including all bin directories under /packages can result in deployment errors depending on which combination of jobs is deployed. For example, Concourse can use busybox which may bring in a new core utility which does not behave as expected, resulting in a failed deployment
- This change scopes the PATH includes to only use /var/vcap/packages/admin_ui bin directories
…ies under /packages can result in deployment errors depending on which combination of jobs is deployed. For example, Concourse can use busybox which may bring in a new core utility which does not behave as expected, resulting in a failed deployment - This change scopes the PATH includes to only use /var/vcap/packages/admin_ui bin directories
Author
|
This package has no dependencies in /var/vcap/packages outside of itself, can we get this merged? |
Author
|
Reminder that this is still an outstanding bug and this is a complete fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.