-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflows binding to create a workflow without arguments #7225
base: main
Are you sure you want to change the base?
Fix workflows binding to create a workflow without arguments #7225
Conversation
🦋 Changeset detectedLatest commit: 9d98a7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-wrangler-7225 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7225/npm-package-wrangler-7225 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-wrangler-7225 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-create-cloudflare-7225 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-kv-asset-handler-7225 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-miniflare-7225 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-pages-shared-7225 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-vitest-pool-workers-7225 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-workers-editor-shared-7225 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-workers-shared-7225 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-workflows-shared-7225 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
public async create( | ||
options: WorkflowInstanceCreateOptions | ||
): Promise<WorkflowInstance> { | ||
const id = options?.id ? options?.id : crypto.randomUUID(); | ||
const params = options?.params ? options?.params : {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this can't be:
public async create( | |
options: WorkflowInstanceCreateOptions | |
): Promise<WorkflowInstance> { | |
const id = options?.id ? options?.id : crypto.randomUUID(); | |
const params = options?.params ? options?.params : {}; | |
public async create( | |
{ id = crypto.randomUUID(), params = {}}: WorkflowInstanceCreateOptions | |
): Promise<WorkflowInstance> { |
Fixes WOR-317.
Fix workflows binding to create a workflow without arguments. If no argument were passed, the wrangler local dev would fail. Now we validate that the arguments exist, and if not, manage the creation of the necessary variables.