Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows binding to create a workflow without arguments #7225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bruxodasilva
Copy link
Contributor

@bruxodasilva bruxodasilva commented Nov 11, 2024

Fixes WOR-317.

Fix workflows binding to create a workflow without arguments. If no argument were passed, the wrangler local dev would fail. Now we validate that the arguments exist, and if not, manage the creation of the necessary variables.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: workflows-shared is managed by the workflows team
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: workflows does not have them
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no modifications to the feature usage

@bruxodasilva bruxodasilva requested a review from a team as a code owner November 11, 2024 15:13
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 9d98a7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workflows-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-wrangler-7225

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7225/npm-package-wrangler-7225

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-wrangler-7225 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-create-cloudflare-7225 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-kv-asset-handler-7225
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-miniflare-7225
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-pages-shared-7225
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-vitest-pool-workers-7225
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-workers-editor-shared-7225
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-workers-shared-7225
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11781314840/npm-package-cloudflare-workflows-shared-7225

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.86.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Comment on lines +16 to +20
public async create(
options: WorkflowInstanceCreateOptions
): Promise<WorkflowInstance> {
const id = options?.id ? options?.id : crypto.randomUUID();
const params = options?.params ? options?.params : {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this can't be:

Suggested change
public async create(
options: WorkflowInstanceCreateOptions
): Promise<WorkflowInstance> {
const id = options?.id ? options?.id : crypto.randomUUID();
const params = options?.params ? options?.params : {};
public async create(
{ id = crypto.randomUUID(), params = {}}: WorkflowInstanceCreateOptions
): Promise<WorkflowInstance> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants