Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-cloudflare): enable nodejs_compact on astro template #7171

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

edmundhung
Copy link
Member

Fixes n/a.

Our create-cloudflare e2e test has been failing getting the preview running on astro for a while (e.g. This CI run). This PR should fix the issue.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no feature change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no feature change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no feature change

@edmundhung edmundhung requested review from a team as code owners November 5, 2024 13:32
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 250d83c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-wrangler-7171

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7171/npm-package-wrangler-7171

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-wrangler-7171 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-create-cloudflare-7171 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-cloudflare-kv-asset-handler-7171
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-miniflare-7171
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-cloudflare-pages-shared-7171
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-cloudflare-vitest-pool-workers-7171
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-cloudflare-workers-editor-shared-7171
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-cloudflare-workers-shared-7171
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11685249097/npm-package-cloudflare-workflows-shared-7171

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.84.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit 5a712e7 into main Nov 5, 2024
30 checks passed
@edmundhung edmundhung deleted the edmundhung/c3-astro-nodejs-compact branch November 5, 2024 14:52
@workers-devprod workers-devprod mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants