-
Notifications
You must be signed in to change notification settings - Fork 1.1k
C3: Update remaining dev and deployment scripts #5187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c395b29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-wrangler-5187You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5187/npm-package-wrangler-5187Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-wrangler-5187 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-create-cloudflare-5187 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-cloudflare-kv-asset-handler-5187npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-miniflare-5187npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-cloudflare-pages-shared-5187npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-cloudflare-vitest-pool-workers-5187Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5187 +/- ##
==========================================
+ Coverage 70.35% 70.38% +0.03%
==========================================
Files 298 298
Lines 15567 15567
Branches 4007 4007
==========================================
+ Hits 10952 10957 +5
+ Misses 4615 4610 -5 |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 😃
701c3a3 to
c395b29
Compare
What this PR solves / how to test
This updates the remaining
webFrameworktemplates to usedevanddeployinstead ofpages:devandpages:deployin their package scripts.It also moves the
testFlagsconfig option for frameworks from their template definitions into the frameworks e2e test config.Author has addressed the following