Skip to content

Conversation

@jculvey
Copy link
Contributor

@jculvey jculvey commented Mar 6, 2024

What this PR solves / how to test

This updates the remaining webFramework templates to use dev and deploy instead of pages:dev and pages:deploy in their package scripts.

It also moves the testFlags config option for frameworks from their template definitions into the frameworks e2e test config.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Existing coverage sufficient
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@jculvey jculvey requested a review from a team March 6, 2024 20:46
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: c395b29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-wrangler-5187

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5187/npm-package-wrangler-5187

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-wrangler-5187 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-create-cloudflare-5187 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-cloudflare-kv-asset-handler-5187
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-miniflare-5187
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-cloudflare-pages-shared-5187
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8198283875/npm-package-cloudflare-vitest-pool-workers-5187

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.32.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240304.0
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (96e4e16) to head (c395b29).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5187      +/-   ##
==========================================
+ Coverage   70.35%   70.38%   +0.03%     
==========================================
  Files         298      298              
  Lines       15567    15567              
  Branches     4007     4007              
==========================================
+ Hits        10952    10957       +5     
+ Misses       4615     4610       -5     

see 5 files with indirect coverage changes

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😃

@jculvey jculvey force-pushed the c3-align-script-names branch from 701c3a3 to c395b29 Compare March 8, 2024 03:22
@jculvey jculvey merged commit 8e9faf2 into main Mar 8, 2024
@jculvey jculvey deleted the c3-align-script-names branch March 8, 2024 03:47
@workers-devprod workers-devprod mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants