Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listen on IPv4 loopback only by default on Windows #4547

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 4, 2023

Closes DEVX-1076

What this PR solves / how to test:

On Windows, when specifying localhost as the socket hostname, workerd will only listen on the IPv4 loopback 127.0.0.1, not the IPv6 ::1: cloudflare/workerd#1408 On Node 17+, fetch() will only try to fetch the IPv6 address. For now, on Windows, this change defaults to listening on IPv4 only and using 127.0.0.1 when sending control requests to workerd (e.g. with the ProxyController).

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested review from a team as code owners December 4, 2023 18:21
Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 5dfcde4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 4, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-wrangler-4547

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7090861576/npm-package-wrangler-4547

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-wrangler-4547 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-miniflare-4547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-cloudflare-pages-shared-4547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-create-cloudflare-4547

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.18.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.2
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #4547 (5dfcde4) into main (71fb0b8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4547      +/-   ##
==========================================
+ Coverage   75.44%   75.48%   +0.04%     
==========================================
  Files         240      240              
  Lines       12854    12855       +1     
  Branches     3312     3313       +1     
==========================================
+ Hits         9698     9704       +6     
+ Misses       3156     3151       -5     
Files Coverage Δ
packages/wrangler/src/config/validation.ts 90.10% <100.00%> (ø)
packages/wrangler/src/pages/dev.ts 16.49% <100.00%> (+0.28%) ⬆️

... and 6 files with indirect coverage changes

@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Dec 4, 2023
@petebacondarwin
Copy link
Contributor

@mrbbot mrbbot merged commit 86c81ff into main Dec 5, 2023
24 checks passed
@mrbbot mrbbot deleted the bcoll/windows-ipv4 branch December 5, 2023 08:17
@workers-devprod workers-devprod mentioned this pull request Dec 5, 2023
penalosa added a commit that referenced this pull request Feb 7, 2024
penalosa added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants