-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: listen on IPv4 loopback only by default on Windows #4547
Conversation
🦋 Changeset detectedLatest commit: 5dfcde4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-wrangler-4547 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7090861576/npm-package-wrangler-4547 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-wrangler-4547 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-miniflare-4547 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-cloudflare-pages-shared-4547 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7090861576/npm-package-create-cloudflare-4547 Note that these links will no longer work once the GitHub Actions artifact expires.
| Please ensure constraints are pinned, and |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4547 +/- ##
==========================================
+ Coverage 75.44% 75.48% +0.04%
==========================================
Files 240 240
Lines 12854 12855 +1
Branches 3312 3313 +1
==========================================
+ Hits 9698 9704 +6
+ Misses 3156 3151 -5
|
E2E tests are green! https://github.com/cloudflare/workers-sdk/actions/runs/7092496026?pr=4547 |
Closes DEVX-1076
What this PR solves / how to test:
On Windows, when specifying
localhost
as the socket hostname,workerd
will only listen on the IPv4 loopback127.0.0.1
, not the IPv6::1
: cloudflare/workerd#1408 On Node 17+,fetch()
will only try to fetch the IPv6 address. For now, on Windows, this change defaults to listening on IPv4 only and using127.0.0.1
when sending control requests toworkerd
(e.g. with theProxyController
).Author has addressed the following:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.