Avoid uploading the functions/ directory as part of wrangler pages publish

[GregBrimble]

Don't upload functions/ directory as part of wrangler pages publish

If the root directory of a project was the same as the build output directory, we were previously uploading the functions/ directory as static assets. This PR now ensures that the functions/ files are only used to create Pages Functions and are no longer uploaded as static assets.

Additionally, we also now do upload _worker.js, _headers, _redirects and _routes.json if they aren't immediate children of the build output directory. Previously, we'd ignore all files with this name regardless of location. For example, if you have a public/blog/how-to-use-pages/_headers file (where public is your build output directory), we will now upload the _headers file as a static asset.

[changeset-bot]

🦋 Changeset detected

Latest commit: ccafb81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3376938856/npm-package-wrangler-2103

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2103/npm-package-wrangler-2103

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/3376938856/npm-package-wrangler-2103 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.developers.workers.dev/runs/3376938856/npm-package-cloudflare-pages-shared-2103

[WalshyDev]

Compiled Worker successfully.
IGNORING functions
IGNORING node_modules

Nice. This looks good to me, looks like a test needs updating

Ty for fixing this!

[codecov]

Codecov Report

Merging #2103 (ccafb81) into main (2a81cae) will increase coverage by 0.09%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
+ Coverage   73.11%   73.20%   +0.09%     
==========================================
  Files         127      128       +1     
  Lines        8610     8641      +31     
  Branches     2264     2266       +2     
==========================================
+ Hits         6295     6326      +31     
  Misses       2315     2315              

Impacted Files	Coverage Δ
packages/wrangler/src/is-interactive.ts	85.71% <50.00%> (-14.29%)	⬇️
packages/wrangler/src/pages/constants.ts	100.00% <100.00%> (ø)
packages/wrangler/src/pages/upload.tsx	85.71% <100.00%> (+0.57%)	⬆️
...ckages/wrangler/src/__tests__/helpers/msw/index.ts	100.00% <0.00%> (ø)
.../src/__tests__/helpers/msw/handlers/deployments.ts	100.00% <0.00%> (ø)
packages/wrangler/src/index.tsx	83.12% <0.00%> (+1.18%)	⬆️
...ackages/wrangler/src/__tests__/helpers/mock-bin.ts	100.00% <0.00%> (+5.26%)	⬆️

[GregBrimble]

Didn't mean to leave in that console.log() — I've removed it now.

[WalshyDev]

I think it might be nice to have a log for it tbh

[GregBrimble]

Maybe we can add it back later with a WRANGLER_LOG_LEVEL or whatever that's called now. Having it by default is quite noisy imo.

[CarmenPopoviciu]

TIL. I had no idea this is happening. Can you please add some tests for the scope of this PR? I'm thinking a unit test to verify that output Walshy mentioned (or smth along those lines)

Compiled Worker successfully.
IGNORING functions
IGNORING node_modules

and maybe a fixture (could also update an existing fixture) to test that _headers, _redirects, etc do get uploaded if not direct children of build output dir. WDYT? Will leave it up to you , just as long as we have something that tests the correct behaviour ¯_(ツ)_/¯

other than that 💯

[isaac-mcfadyen]

I'd warn against logging it or reword the message or something. If I'm a new user and I don't know what it means, it looks like wrangler just ignored all of my Functions (even for regular Function things).