[wrangler] Split cloudchamber curl headers on the first colon only - #14815
Conversation
@cloudflare/autoconfig
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
c6a9852 to
602df6a
Compare
🦋 Changeset detectedLatest commit: a464238 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
Thank you for you PR, but we are no longer considering PRs submitted without issues. If you believe this constitutes a valid, user-facing bug, please create a bug report with a minimal reproduction and we will triage it appropriately. |
|
Re-opening as this is a valid bug that now has an issue |
602df6a to
72d351b
Compare
|
Thanks for reopening this, and you're right — that test asserted the wrong behaviour. A colon-less Pushed a464238:
Changeset updated to match, since it previously described the empty-value behaviour. Full |
|
Just needs approval from the cloudchamber/containers team... cc @emily-shen |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
wrangler cloudchamber curlbuilds request headers by splitting each--headeron every colon and taking only the segment between the first and second:Two consequences:
--header location:https://example.com/xis sent aslocation: https.--header Foo) makes[1]undefined, so.trim()throws aTypeError, which is caught and printed instead of the request being made.This splits on the first colon only and keeps the remainder as the value, matching what
collectKeyValues.tsalready does. Added two tests; both fail before this change.