-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: address issue #2634 #12215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: address issue #2634 #12215
Conversation
Automated issue triage and fixing powered by OpenCode.
- Use string comparison for isTeamMember check (was comparing string to boolean) - Add git user config for workers-devprod bot before commit
- Use env vars instead of template literals to prevent JS injection in parse step - Use env vars instead of shell interpolation to prevent shell injection in test step - Use randomized heredoc delimiter to prevent delimiter collision in patch capture
- Switch to anthropics/claude-code-action@v1 - Use 'prompt' and 'claude_args' instead of deprecated inputs - Use structured_output with --json-schema for assessment parsing - Rename workflow to 'Autofix' and branch prefix to 'autofix/' - Reference AGENTS.md for guidelines
Claude Code action doesn't automatically fetch issue context in automation mode, so we explicitly fetch issue title/body/labels and include them in the prompts for both assessment and fix steps.
Automated fix generated by Autofix. Closes #2634
🦋 Changeset detectedLatest commit: 74fc73c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @workers-devprod's task —— View job Changeset Review✅ All changesets look good The changeset
The changeset follows all guidelines from
|
|
@claude this PR doesn't have tests. Can you add some? |
|
Claude finished @penalosa's task —— View job ✅ Tests Added SuccessfullyI've added comprehensive tests for the Todo List
AnalysisThe changes add a
Tests AddedI've added comprehensive tests to
The tests use the existing test infrastructure including Changes Committed
The PR now has comprehensive test coverage for the new |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Tests verify that: - runCommand sets WRANGLER_COMMAND for dev, deploy, versions upload, and types commands - runCommand doesn't set WRANGLER_COMMAND when wranglerCommand is undefined - runCustomBuild properly passes through WRANGLER_COMMAND for all command types Co-authored-by: Somhairle MacLeòid <penalosa@users.noreply.github.com>
Fixes #2634.
🤖✨ Beep boop! I think I've squashed this bug! All automated tests are passing, but my silicon brain might have missed something—would love a human review before this gets merged.