Skip to content

Conversation

@dario-piotrowicz
Copy link
Member


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: the open-next detection is not a documented feature
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: the open-next detection is not in v3

A picture of a cute animal (not mandatory, but encouraged)

…to eliminate false positives for non open-next projects
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 18, 2025 11:23
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

🦋 Changeset detected

Latest commit: 88ec83f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Dec 18, 2025

Claude finished @dario-piotrowicz's task —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Validate against criteria
  • Post findings

⚠️ Issues found

The changeset .changeset/vast-regions-chew.md has the following issue:

Changelog Quality - Missing context and user impact

The current description:

fix: improve the open-next detection that `wrangler deploy` performs to eliminate false positives for non open-next projects

According to the guidelines, bug fix changesets should describe the symptom that was fixed and provide enough context for users to understand the impact. The current description:

  • Uses "fix:" prefix which isn't necessary in changesets (the title should be a plain imperative sentence)
  • Doesn't explain what the false positive was or how it manifested
  • Doesn't describe what users experienced before the fix

Suggested improvement:

---
"wrangler": patch
---

Fix `wrangler deploy` incorrectly detecting non-OpenNext projects as OpenNext projects

Previously, `wrangler deploy` could incorrectly identify projects as OpenNext deployments based on incomplete checks, potentially causing deployment issues for unrelated projects. The detection logic has been improved to eliminate these false positives.

This follows the pattern from the guidelines' bug fix example, clearly stating:

  1. What command/feature was affected
  2. What symptom users experienced
  3. What the fix does

Validation summary:

  • ✅ Version Type: Correct (patch for bug fix)
  • ✅ Package: Correct (wrangler)
  • ✅ Major version: Not applicable (patch bump)
  • ✅ Markdown Headers: None used (compliant)
  • ⚠️ Changelog Quality: Needs improvement to describe the symptom

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/avoid-open-next-deploy-false-positives might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11694
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11694

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11694

miniflare

npm i https://pkg.pr.new/miniflare@11694

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11694

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11694

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11694

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11694

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11694

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11694

wrangler

npm i https://pkg.pr.new/wrangler@11694

commit: 88ec83f

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 18, 2025
@edmundhung edmundhung merged commit 3853200 into main Dec 18, 2025
42 of 43 checks passed
@edmundhung edmundhung deleted the dario/avoid-open-next-deploy-false-positives branch December 18, 2025 12:16
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 18, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
…to eliminate false positives for non open-next projects (cloudflare#11694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants