-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: improve the open-next detection that wrangler deploy performs to eliminate false positives for non open-next projects
#11694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to eliminate false positives for non open-next projects
🦋 Changeset detectedLatest commit: 88ec83f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude finished @dario-piotrowicz's task —— View job Changeset Review
The changeset Changelog Quality - Missing context and user impact The current description: According to the guidelines, bug fix changesets should describe the symptom that was fixed and provide enough context for users to understand the impact. The current description:
Suggested improvement: ---
"wrangler": patch
---
Fix `wrangler deploy` incorrectly detecting non-OpenNext projects as OpenNext projects
Previously, `wrangler deploy` could incorrectly identify projects as OpenNext deployments based on incomplete checks, potentially causing deployment issues for unrelated projects. The detection logic has been improved to eliminate these false positives.This follows the pattern from the guidelines' bug fix example, clearly stating:
Validation summary:
|
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
ascorbic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
…to eliminate false positives for non open-next projects (cloudflare#11694)
A picture of a cute animal (not mandatory, but encouraged)