Skip to content

Conversation

@jamesopstad
Copy link
Contributor

@jamesopstad jamesopstad commented Dec 16, 2025

Provide the resolved entry Worker config as the second parameter to the auxiliary Worker config function. This makes it straightforward to inherit configuration from the entry Worker in auxiliary Workers.

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2025

🦋 Changeset detected

Latest commit: 5a052b8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 16, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11670

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11670

miniflare

npm i https://pkg.pr.new/miniflare@11670

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11670

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11670

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11670

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11670

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11670

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11670

wrangler

npm i https://pkg.pr.new/wrangler@11670

commit: 5a052b8

@claude
Copy link
Contributor

claude bot commented Dec 16, 2025

Claude finished @jamesopstad's task in 33s —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Validate and provide feedback

Changeset looks good!

The changeset .changeset/funny-vans-shake.md passes all validation criteria:

Version Type

  • minor - Correct for a new feature (adding entryWorkerConfig parameter)
  • Package: @cloudflare/vite-plugin (not wrangler, so no major version restriction applies)

Changelog Quality

  • Clear title describing the feature
  • Good explanation of the benefit ("makes it straightforward to inherit configuration")
  • Includes a complete usage example showing how to use the new parameter
  • Example demonstrates a real-world use case (inheriting compatibility settings)

Markdown Headers

  • No h1/h2/h3 headers used ✓

The changeset follows all guidelines and provides excellent documentation for users.

@jamesopstad jamesopstad changed the title Provide entry Worker config to auxiliary Worker config customizers Provide entry Worker config to auxiliary Worker config function Dec 16, 2025
@jamesopstad jamesopstad force-pushed the james/entry-worker-config-param branch from 7b8b24f to 89477d7 Compare December 16, 2025 16:48
@jamesopstad jamesopstad marked this pull request as ready for review December 16, 2025 16:48
@jamesopstad jamesopstad requested a review from a team as a code owner December 16, 2025 16:48
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! great change

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 16, 2025
@jamesopstad jamesopstad merged commit 3483b84 into main Dec 16, 2025
37 of 38 checks passed
@jamesopstad jamesopstad deleted the james/entry-worker-config-param branch December 16, 2025 17:28
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 16, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
…dflare#11670)

* Update auxiliary Worker config function to receive entryWorkerConfig as second argument

* Fix existing tests

* Add tests

* Add changeset

* Fix casing in changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants