[c3] make sure comments are always added to the end of wrangler.jsonc #11597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 768b922 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
approved these changes
Dec 11, 2025
vicb
force-pushed
the
vicb/json-comment
branch
from
2783dfb to
768b922
Compare
Contributor
Author
|
Thanks for the review Pete! I forced push to rebase and fix a conflict with main. |
Merged
dario-piotrowicz
pushed a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the comment in
wrangler.jsoncwas added after theobservabilityproperty - meaning that it is expected to be last in your template and I ran into the issue for the Open Next template.I asked on the repo and there is actually an
afterlocation we can use.Because
afterwas not in the types of the version that was used, I bumped it to the latest and updated the corresponding npm patch.A picture of a cute animal (not mandatory, but encouraged)