-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Wrangler] Add Workflows sendEvent wrangler command #11590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d18edef The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
ba59a07 to
4dec5aa
Compare
|
LGTM from the workflows team |
packages/wrangler/src/workflows/commands/instances/send-event.ts
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please get an approval from within your team first ?
(That's the usual process from contributions originating from outside the ANT team).
Thanks
I have an approval from my team. Caio left a comment above |
packages/wrangler/src/workflows/commands/instances/send-event.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/workflows/commands/instances/send-event.ts
Outdated
Show resolved
Hide resolved
0954bb1 to
c2890de
Compare
packages/wrangler/src/workflows/commands/instances/send-event.ts
Outdated
Show resolved
Hide resolved
c2890de to
0dea233
Compare
vicb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
And sorry for the localeCompare thingy, now I understand that the reason for having this is that there is no non-locale aware variant of it
0dea233 to
d18edef
Compare
* [Wrangler] Add Workflows sendEvent wrangler command * Apply comment suggestions * Apply review suggestions * Refactor some repeated code and remove localeCompare * Revert removal of localeCompare
Fixes WOR-1057.
This adds a new command to wrangler
wrangler workflows instances send-event <name> <id>with options--typeand--payloadto allow users to just call this command to send an event to a deployed running workflow instance rather than having to implement it themselves or having to use the API.A picture of a cute animal (not mandatory, but encouraged)

Okay, if you really want... here is the cutest dog (@sidharthachatterjee) Now try not to fall in love