-
Notifications
You must be signed in to change notification settings - Fork 1.1k
implement r2 bulk put #11285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement r2 bulk put #11285
Conversation
🦋 Changeset detectedLatest commit: 12b99a7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
9f43ef1 to
8669d35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extracted from the former r2/helper.ts without updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extracted from the former r2/helper.ts without updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extracted from the former r2/helper.ts without updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extracted from the former r2/helper.ts without updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extracted from the former r2/helper.ts without updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extracted from the former r2/helper.ts without updates
petebacondarwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - with a few nits
|
Thanks for the review Pete, I have applied your feedback |
Add support for
wrangler r2 bulk put bucket-name --filename list.jsonIt supports the same options as
wrangler r2 object put, minus--fileand--pipeand plus--concurrencyNotes for reviewers:
r2/helpers.tshas been splitted into different filesr2/helpers/<what.ts>object.ts(used by the bulk command) are unchangedbulk.tsFuture work (will create issues before merging this PR)
wrangler r2 bulk put bucket-name --folder /path/to/folderto upload a folder to R2wrangler r2 bulk get bucket-name --folder /path/to/folderto download a folder from R2TODO:
p-queuev9