Use smol-toml for TOML parsing
#11266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a809b06 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
vicb
reviewed
Nov 13, 2025
vicb
reviewed
Nov 13, 2025
edmundhung
reviewed
Nov 13, 2025
packages/wrangler/src/__tests__/queues/__snapshots__/queues.test.ts.snap
Show resolved
Hide resolved
vicb
reviewed
Nov 13, 2025
| binding = \\"UnitTestNamespace\\" | ||
| id = \\"some-namespace-id\\" | ||
| " | ||
| id = \\"some-namespace-id\\"" |
Contributor
There was a problem hiding this comment.
Well, what this means is that smol-toml never ends files with a newline, which for many is undesirable.
vicb
reviewed
Nov 13, 2025
| exports[`pages deploy > with wrangler.json configuration > should warn and ignore the config file, if it doesn't specify the \`pages_build_output_dir\` field 1`] = `[Error: Must specify a project name.]`; | ||
|
|
||
| exports[`pages deploy > with wrangler.toml configuration > should always deploy to the Pages project specified by the top-level \`name\` configuration field, regardless of the corresponding env-level configuration 1`] = `"b5f53af7922efd0f0b73c7bf288f7e3f14df5c31e8b654e98027ddf85ea7e574"`; | ||
| exports[`pages deploy > with wrangler.toml configuration > should always deploy to the Pages project specified by the top-level \`name\` configuration field, regardless of the corresponding env-level configuration 1`] = `"407a6bdab238180ecb96088b70f740fb2c9a91c179a4291486894f068f054422"`; |
vicb
approved these changes
Nov 13, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
LGTM with minor comments/questions
Contributor
Author
|
Having reviewed the stylistic changes here more closely, I'm no longer sure about this... [queues]
[[queues.producers]]
queue = \\"testQueue\\"
binding = \\"testQueue\\"
[containers.configuration.observability]
[containers.configuration.observability.logs]
enabled = trueseems worse than the previous [[queues.producers]]
queue = \\"testQueue\\"
binding = \\"testQueue\\"
[containers.configuration.observability.logs]
enabled = trueand multiline strings seem quite different (they're no longer multiline...) |
Contributor
Author
|
I've put up a PR to |
penalosa
force-pushed
the
penalosa/smol-toml
branch
3 times, most recently
from
199e3fc to
6cbf8ec
Compare
penalosa
force-pushed
the
penalosa/smol-toml
branch
from
6cbf8ec to
929cfc9
Compare
petebacondarwin
approved these changes
Nov 14, 2025
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Just a minor worry that we are now adding an extra newline to the end of each stringified TOML, which may look weird in logged snippets?
petebacondarwin
force-pushed
the
penalosa/smol-toml
branch
from
425b95a to
4208357
Compare
cyyynthia
reviewed
Nov 14, 2025
petebacondarwin
force-pushed
the
penalosa/smol-toml
branch
from
4208357 to
35e9e43
Compare
petebacondarwin
approved these changes
Nov 14, 2025
petebacondarwin
force-pushed
the
penalosa/smol-toml
branch
from
35e9e43 to
a809b06
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
@iarna/tomltosmol-toml.@iarna/tomlno longer appears to be maintained, andsmol-tomlis a more popular alternative that's also crucially ESM rather than CJS—getting us one step closer to having a fully ESM Wrangler build.