Update dependencies across the repository #11204

penalosa · 2025-11-06T19:10:57Z

A mix of outdated dependencies, fixing peer dependency warnings, running pnpm dedupe. See individual commits for details

Tests
- Tests included
- Tests not necessary because: existing tests should pass
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: internal refactor
Wrangler V3 Backport
- Wrangler PR:
- Not necessary because: refactor

…sed ws/MSW to drop the request host from the URL, breaking MSW

…ortunately cloudflare's types are pretty messy, so this is a bit of a messy change. However, in the spirit of dogfooding I think it's worth it—these warts will go away in time

…asset-handler tests. This package is no longer maintained or supported, and so I only made the minimal changes required to make it run, rather than the _actual_ right thing to do (migrate to vitest-pool-workers so that the tests run in a real environment

changeset-bot · 2025-11-06T19:11:01Z

🦋 Changeset detected

Latest commit: fa078ee

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-11-06T19:14:13Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11204

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11204

miniflare

npm i https://pkg.pr.new/miniflare@11204

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11204

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11204

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11204

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11204

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11204

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11204

wrangler

npm i https://pkg.pr.new/wrangler@11204

commit: fa078ee

github-actions · 2025-11-07T03:08:14Z

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/update-deps might be a good starting point.

Notes:

your PR branch should be named v3-backport-11204
add the skip-v3-pr label to the current PR to stop this workflow from failing

petebacondarwin · 2025-11-07T12:28:12Z

packages/workflows-shared/tests/engine.test.ts

 		}

-		await engineStub.receiveEvent({
+		const newStub = env.ENGINE.get(env.ENGINE.idFromName("MOCK-INSTANCE-ID"));


Why do we need to get a new stub for the same instance here?

petebacondarwin · 2025-11-07T13:00:59Z

packages/vite-plugin-cloudflare/e2e/fixtures/basic/package.json

 	"dependencies": {
-		"react": "^19.0.0",
-		"react-dom": "^19.0.0"
+		"react": "~19.0.0",


OK so 19.2 is broken but most of these are currently on 19.1.xx.
Shouldn't these all be ~19.1.0 then?

I saw you fixed this in a later commit

After further digging, it turned out to be 19.1.1 that's the first broken version

penalosa · 2025-11-07T12:20:33Z

.github/workflows/test-and-check.yml

            node_version: 22
            # Browser rendering is disabled here because of https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu
-            filter: '--filter="./packages/*" --filter="./fixtures/*" --filter="./packages/vite-plugin-cloudflare/playground" --filter="!./packages/kv-asset-handler" --filter="!./fixtures/browser-rendering"'
+            filter: '--filter="./packages/*" --filter="./fixtures/*" --filter="./packages/vite-plugin-cloudflare/playground" --filter="!./fixtures/browser-rendering"'


kv-asset-handler no longer fails on node 22!

penalosa · 2025-11-07T12:21:30Z

packages/kv-asset-handler/src/test/getAssetFromKV.ts

+test.skip("getAssetFromKV non ASCII path support", async (t) => {
 	mockRequestScope();
 	const event = getEvent(new Request("https://blah.com/测试.html"));
 	const res = await getAssetFromKV(event);

 	if (res) {
 		t.is(await res.text(), "My filename is non-ascii");
 	} else {
 		t.fail("Response was undefined");
 	}
 });

 test("getAssetFromKV supports browser percent encoded URLs", async (t) => {
 	mockRequestScope();
 	const event = getEvent(
 		new Request("https://example.com/%not-really-percent-encoded.html")
 	);
 	const res = await getAssetFromKV(event);

 	if (res) {
 		t.is(await res.text(), "browser percent encoded");
 	} else {
 		t.fail("Response was undefined");
 	}
 });

 test("getAssetFromKV supports user percent encoded URLs", async (t) => {
 	mockRequestScope();
 	const event = getEvent(new Request("https://blah.com/%2F.html"));
 	const res = await getAssetFromKV(event);

 	if (res) {
 		t.is(await res.text(), "user percent encoded");
 	} else {
 		t.fail("Response was undefined");
 	}
 });

 test("getAssetFromKV only decode URL when necessary", async (t) => {
 	mockRequestScope();
 	const event1 = getEvent(
 		new Request("https://blah.com/%E4%BD%A0%E5%A5%BD.html")
 	);
 	const event2 = getEvent(new Request("https://blah.com/你好.html"));
 	const res1 = await getAssetFromKV(event1);
 	const res2 = await getAssetFromKV(event2);

 	if (res1 && res2) {
 		t.is(await res1.text(), "Im important");
 		t.is(await res2.text(), "Im important");
 	} else {
 		t.fail("Response was undefined");
 	}
 });

-test("getAssetFromKV Support for user decode url path", async (t) => {
+test.skip("getAssetFromKV Support for user decode url path", async (t) => {


These probably should be made to work, but the complexity of fixing them doesn't seem worth it, given we no longer support the package.

penalosa · 2025-11-07T13:08:10Z

packages/vite-plugin-cloudflare/e2e/fixtures/basic/package.json

 	"dependencies": {
-		"react": "^19.0.0",
-		"react-dom": "^19.0.0"
+		"react": "~19.0.0",


After further digging, it turned out to be 19.1.1 that's the first broken version

penalosa · 2025-11-07T13:33:23Z

This keeps going stale. I'm going to try and land the individual commits as individual PRs

penalosa added 7 commits November 6, 2025 14:43

pnpm dedupe & bump toucan-js to v4 across the board

f9faa22

Bump vitest-pool-workers & fix failing workflows-shared test

e796400

Fix more vitest things

46d2bab

Bump deps to support Vite 7

86cc7bc

Bump to latest MSW & fix bug in ProxyController where multiple // cau…

d00e3f5

…sed ws/MSW to drop the request host from the URL, breaking MSW

Use cloudflare for Pages API types rather than @cloudflare/types. Unf…

5c02ce9

…ortunately cloudflare's types are pretty messy, so this is a bit of a messy change. However, in the spirit of dogfooding I think it's worth it—these warts will go away in time

penalosa requested review from a team as code owners November 6, 2025 19:10

workers-devprod added this to workers-sdk Nov 6, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Nov 6, 2025

penalosa added 4 commits November 7, 2025 01:54

Run pnpm dedupe again

6403678

fix check

013cafe

pin react? something's up in 19.2

c1d26a9

add changeset

81d5198

penalosa added 4 commits November 7, 2025 03:14

pin react? something's up in 19.2

1116e2d

pin react? something's up in 19.2

7b926ba

bump workerd

a0c87f6

Merge remote-tracking branch 'origin/main' into penalosa/update-deps

fa078ee

penalosa added the skip-v3-pr label Nov 7, 2025

petebacondarwin reviewed Nov 7, 2025

View reviewed changes

penalosa commented Nov 7, 2025

View reviewed changes

penalosa closed this Nov 7, 2025

github-project-automation bot moved this from Untriaged to Done in workers-sdk Nov 7, 2025

penalosa mentioned this pull request Nov 7, 2025

Bump to toucan v4 #11217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update dependencies across the repository #11204

Update dependencies across the repository #11204

Uh oh!

penalosa commented Nov 6, 2025

Uh oh!

changeset-bot bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

petebacondarwin Nov 7, 2025

Uh oh!

petebacondarwin Nov 7, 2025

Uh oh!

petebacondarwin Nov 7, 2025

Uh oh!

penalosa Nov 7, 2025

Uh oh!

penalosa Nov 7, 2025

Uh oh!

penalosa Nov 7, 2025

Uh oh!

penalosa Nov 7, 2025

Uh oh!

penalosa commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Update dependencies across the repository #11204

Update dependencies across the repository #11204

Uh oh!

Conversation

penalosa commented Nov 6, 2025

Uh oh!

changeset-bot bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

petebacondarwin Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

penalosa Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

penalosa Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

penalosa Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

penalosa Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

penalosa commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Nov 6, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 6, 2025 •

edited

Loading