Skip to content

Conversation

@FlorentCollin
Copy link

@FlorentCollin FlorentCollin commented Oct 31, 2025

This PR improves the formatting of the D1 execute command to always show the duration in milliseconds with 2 decimal places.

This change is part of this internal ticket CFSQL-1403

@FlorentCollin FlorentCollin requested review from a team as code owners October 31, 2025 09:31
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: 701bc8e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 31, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11143

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11143

miniflare

npm i https://pkg.pr.new/miniflare@11143

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11143

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11143

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11143

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11143

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11143

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11143

wrangler

npm i https://pkg.pr.new/wrangler@11143

commit: 701bc8e

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 31, 2025
@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1403-d1-executed-commands-round-duration branch from 1ad314d to ad59bd0 Compare October 31, 2025 10:12
This improves the precision of timing information for D1 query
performance analysis.
@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1403-d1-executed-commands-round-duration branch from ad59bd0 to c1aecda Compare October 31, 2025 13:38
@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1403-d1-executed-commands-round-duration branch from c1aecda to 494caab Compare October 31, 2025 13:46
@dario-piotrowicz dario-piotrowicz added the skip-v3-pr Skip validation of presence of a v3 backport PR label Nov 3, 2025
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except the 4 instead of 2 in the tests descriptions 😄

@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1403-d1-executed-commands-round-duration branch from 494caab to 7d5b648 Compare November 3, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

4 participants