- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1k
 
Improve D1 execute duration formatting precision #11143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve D1 execute duration formatting precision #11143
Conversation
          🦋 Changeset detectedLatest commit: 701bc8e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
          create-cloudflare
 @cloudflare/kv-asset-handler
 miniflare
 @cloudflare/pages-shared
 @cloudflare/unenv-preset
 @cloudflare/vite-plugin
 @cloudflare/vitest-pool-workers
 @cloudflare/workers-editor-shared
 @cloudflare/workers-utils
 wrangler
 commit:   | 
    
1ad314d    to
    ad59bd0      
    Compare
  
    This improves the precision of timing information for D1 query performance analysis.
ad59bd0    to
    c1aecda      
    Compare
  
    c1aecda    to
    494caab      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except the 4 instead of 2 in the tests descriptions 😄
494caab    to
    7d5b648      
    Compare
  
    
This PR improves the formatting of the D1 execute command to always show the duration in milliseconds with 2 decimal places.
This change is part of this internal ticket CFSQL-1403