Fix cron trigger documentation links and inline testing instructions #11139
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated documentation links to point to the correct cron triggers page - Inlined instructions for testing cron triggers locally in the error message - Users now see the curl command directly in the warning instead of having to click through to docs Co-Authored-By: Steve Faulkner <southpolesteve@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: 9444d73 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Changed 'Miniflare does not currently trigger scheduled Workers automatically' to 'Scheduled Workers are not automatically triggered during local development' to make the message more user-friendly and avoid referencing internal implementation details. Co-Authored-By: Steve Faulkner <southpolesteve@gmail.com>
penalosa
reviewed
Oct 30, 2025
…ve messaging - Update curl endpoint from /cdn-cgi/mf/scheduled to /cdn-cgi/handler/scheduled - Replace manual didWarnMiniflareCronSupport flag with logger.once.warn() - Remove 'wrangler dev --local' recommendation since warning appears during dev - Make host/port dynamic using config.initialIp and config.initialPort - Handle IPv6 addresses with brackets and 0.0.0.0/:: as localhost - Update template files to use new endpoint and remove --local flag Co-Authored-By: Steve Faulkner <southpolesteve@gmail.com>
|
Thanks for the feedback! I've addressed all your comments:
All changes have been pushed and are ready for review! |
petebacondarwin
approved these changes
Oct 31, 2025
workers-devprod
added
the
contribution
|
Congratulations @devin-ai-integration[bot], the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmheug8zz007tl804vqtbg8yk This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devin PR requested by @southpolesteve
Addresses PR feedback on #11139 to improve cron trigger documentation and user-facing messaging.
Changes
Updated endpoint from legacy to current:
/cdn-cgi/mf/scheduled→/cdn-cgi/handler/scheduledthroughout codebasepackages/wrangler/src/dev/miniflare/index.tsnew-worker-scheduled.jsand.ts)Improved warning message UX:
wrangler dev --local" to just show the curl command (since warning appears during dev)didWarnMiniflareCronSupportflag withlogger.once.warn()config.initialIpandconfig.initialPortFixed documentation links:
#test-cron-triggersto#test-cron-triggers-locallyReview Focus Areas
packages/wrangler/src/dev/miniflare/index.ts:830-836): IPv6 detection using.includes(":")- verify this handles all edge cases correctly/cdn-cgi/handler/scheduledis universally correct and won't break existing workflowswrangler dev(without--local) is the correct recommendation for testing cron triggers