backport #10915 (show self-bindings as connected) #11108
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99c1d45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
emily-shen
added
skip-pr-description-validation
Fixes #8970 Self-bindings (service bindings where a worker binds to itself) were incorrectly showing as [not connected] in wrangler dev. This change detects self-bindings by comparing the service name to the worker name and always marks them as connected, since a worker is inherently connected to itself. - Modified print-bindings.ts to check for self-bindings before registry lookup - Added test for self-bindings showing as [connected] - Manually verified with workers-with-assets fixture Co-Authored-By: smacleod@cloudflare.com <smacleod@cloudflare.com>
emily-shen
force-pushed
the
emily/backport-10915
branch
from
cfbacee to
99c1d45
Compare
lrapoport-cf
added
the
v3-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #10915 (show self-bindings as connected)