Skip to content

Conversation

@nikitassharma
Copy link
Member

@nikitassharma nikitassharma commented Oct 24, 2025

Fixes CC-6312

DO migrations block version uploads. Currently, the only reliable way to check if a DO migration is to run wrangler versions upload and inspect the error to determine if it's a result of an unsupported DO migration. This is especially important for CI scripting to determine if changes should be deployed instead of uploading a version. Also addresses #10965.

Design decisions made by this pr:

  • Uses wrangler check do-migrations to avoid confusion with D1 migrations
  • This information was not added to a --dry-run call to avoid making API calls on a dry run
    • Avoids making the assumption that version uploads will not support DO migrations in the future.

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: wrangler check isn't documented
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not in v3

@nikitassharma nikitassharma added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 24, 2025
@nikitassharma nikitassharma requested a review from a team as a code owner October 24, 2025 22:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: 3b19247

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11096

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11096

miniflare

npm i https://pkg.pr.new/miniflare@11096

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11096

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11096

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11096

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11096

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11096

wrangler

npm i https://pkg.pr.new/wrangler@11096

commit: 3b19247

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts :(


export const checkNamespace = createNamespace({
metadata: {
description: "🔍 Check pending migrations for your Worker",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "🔍 Check pending migrations for your Worker",
description: "🔍 Check pending migrations for your Durable Object",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants