Skip to content

Provide flag defaults #11092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Provide flag defaults #11092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c850c6f
Provide flag defaults
penalosa Oct 24, 2025
e13b812
Create cuddly-grapes-invent.md
penalosa Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-grapes-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Provide defaults for some internal experimental flags. This should have no impact on usage of Wrangler.
3 changes: 3 additions & 0 deletions fixtures/get-platform-proxy/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
"binding": "MY_KV",
"id": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
},
{
"binding": "MY_PROVISIONED_KV",
},
],
"r2_buckets": [
{
Expand Down
9 changes: 8 additions & 1 deletion packages/wrangler/src/experimental-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ export type ExperimentalFlags = {
AUTOCREATE_RESOURCES: boolean;
};

// In some contexts (e.g. getPlatformProxy) we don't necessarily have a flag store
// instantiated when we want to read a value. This provides defaults for some flags in those cases
const flagDefaults: Partial<Record<keyof ExperimentalFlags, boolean>> = {
RESOURCES_PROVISION: true,
AUTOCREATE_RESOURCES: true,
};

const flags = new AsyncLocalStorage<ExperimentalFlags>();

export const run = <V>(flagValues: ExperimentalFlags, cb: () => V) =>
Expand All @@ -24,5 +31,5 @@ export const getFlag = <F extends keyof ExperimentalFlags>(flag: F) => {
`Attempted to use flag "${flag}" which has not been instantiated`
);
}
return value;
return value ?? flagDefaults[flag];
};
Loading