Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Oct 24, 2025

IMO it's better to move the alias back to unenv.

Two main reasons:

  • Easier to understand if aliases are not spread across unenv, the cloudfalre preset, and the hybrid plugin
  • Both Vite and wrangler/esbuild are using unenv so it's better to factor things there (note that Vite is not using the npm shims at the moment).

Context: the latest release of unenv rewrites the shim for the debug package and I was trying to understand how that would affect us. It will not as both wrangler and Vite use the original package rather than the shim.


  • Tests
    • Tests included
    • Tests not necessary because: this is a refactoring and there are already tests to cover the behaviour.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: unenv changes are not backported

@vicb vicb requested review from a team as code owners October 24, 2025 07:22
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: e4726ed

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/unenv-debug might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11079
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11079

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11079

miniflare

npm i https://pkg.pr.new/miniflare@11079

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11079

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11079

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11079

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11079

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11079

wrangler

npm i https://pkg.pr.new/wrangler@11079

commit: e4726ed

@petebacondarwin
Copy link
Contributor

Appears to have broken the vite node.js tests

@vicb vicb added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 24, 2025
@vicb vicb force-pushed the vicb/unenv-debug branch from a62835b to e4726ed Compare October 24, 2025 12:36
@vicb
Copy link
Contributor Author

vicb commented Oct 24, 2025

force pushed to rebase on top of #11083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants