[vitest-pool-workers] Fix Workflow binding's script_name when it matches its own Worker name

[pombosilva]

Fixes WOR-760.

A user can define a Workflow binding where the script_name is the same as the name of the Worker on which the binding is defined. Although redundant, it should be supported.

vitest-pool-workers breaks because it does not use the user's Worker as the test entrypoint. It uses its own runner worker, which has a different name generated before execution. This leads to a mismatch between the script_name in the binding and the Worker that will run.

To fix this, the code now checks it a workflow binding's script_name matches its own Worker's name. When it does, script_name is removed, making it default to the current worker.

---

• Tests
  • Tests included
  • Tests not necessary because: bug not reproduced in fixtures for some unknown reason
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: only makes vitest-pool-workers not break in a specific case for Workflows
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: does not affect wrangler

[changeset-bot]

🦋 Changeset detected

Latest commit: dbf9e1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10033

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10033

miniflare

npm i https://pkg.pr.new/miniflare@10033

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10033

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10033

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10033

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10033

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10033

wrangler

npm i https://pkg.pr.new/wrangler@10033

commit: dbf9e1d

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main fix/workflows-vitest-pool-workers-script-name might be a good starting point.

Notes:

• your PR branch should be named v3-backport-10033
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[LuisDuarte1]

Approved from the workflows team.

[emily-shen]

I think the name is available under project.project.name so you won't have to re-read the wrangler config

[emily-shen]

but if Pete's suggestion to strip out the name works, that'd be great as its much simpler

[petebacondarwin]

but if Pete's suggestion to strip out the name works, that'd be great as its much simpler

I think we'd still need to know the Worker name in case it is actually pointing to a different Worker not itself?

[emily-shen]

but if Pete's suggestion to strip out the name works, that'd be great as its much simpler

I think we'd still need to know the Worker name in case it is actually pointing to a different Worker not itself?

oh sorry fair enough - i guess check if it matches project.project.name, and strip it out if it does?

[pombosilva]

but if Pete's suggestion to strip out the name works, that'd be great as its much simpler

I think we'd still need to know the Worker name in case it is actually pointing to a different Worker not itself?

oh sorry fair enough - i guess check if it matches project.project.name, and strip it out if it does?

Yes, I'll do it, however I'm not able to get the worker name through project.project.name. It actually returns nothing