Skip to content

In remote diff check add some mechanism to keep remote configs in sync #10373

@dario-piotrowicz

Description

@dario-piotrowicz

In the remote diff check introduced in #10314

We need to compare the local config options with the remote ones, for this we need to somehow know/keep track of which options are local-only and while are also represented remotely (without such information we'd always detect local-only changes as additions).

Currently this is implemented via the remoteConfigKeys set:

const remoteConfigKeys = new Set<string>([

We should put in place some mechanism to make sure that when new configuration options (such as new bindings for example) the information about which config options are local-only and which are remote is kept in sync (possibly some unit tests?).

Ref: #10314 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions