- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1k
Closed as not planned
Description
In the remote diff check introduced in #10314 one thing is missing regarding workers_dev, the fact that the value can implicitly changed based on the presence of routes:
workers-sdk/packages/wrangler/src/triggers/deploy.ts
Lines 55 to 56 in 0c04da9
| const deployToWorkersDev = config.workers_dev ?? routes.length === 0; | |
We do not want to include workers_dev in the diff output since the diff output should only include the raw config authored by the user. So the solution here should be to keep the diffing logic as is but also add an additional check to make sure that wrangler deploy lets the user know if there is a conflict between the implicit value of this field and the remote one.
Something along the lines of:
Although not set in the config file, the `workers_dev` is implicitly set to `false`, which is different from the remote `workers_dev` value of `true`, deploying will override this setting, do you wish to continue?"
Ref: #10314 (comment)
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done