Skip to content

Add HTMLRewriter class in Python SDK#5945

Draft
ryanking13 wants to merge 1 commit intomainfrom
gyeongjae/htmlrewriter-2
Draft

Add HTMLRewriter class in Python SDK#5945
ryanking13 wants to merge 1 commit intomainfrom
gyeongjae/htmlrewriter-2

Conversation

@ryanking13
Copy link
Contributor

This adds HTMLRewriter class in Python SDK, which does proxy lifetime handling internally.

We have an example that uses HTMLRewriter, but it uses JS API directly which is slightly annoying to use in Python because of the proxy handling.

@ryanking13 ryanking13 requested review from a team as code owners January 22, 2026 09:04
@ryanking13 ryanking13 marked this pull request as draft January 22, 2026 16:20
@ryanking13 ryanking13 force-pushed the gyeongjae/htmlrewriter-2 branch from d71bcaa to 41c35e0 Compare January 23, 2026 04:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.01%. Comparing base (66745cd) to head (4f0e824).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5945   +/-   ##
=======================================
  Coverage   70.01%   70.01%           
=======================================
  Files         406      406           
  Lines      107106   107106           
  Branches    17965    17965           
=======================================
+ Hits        74988    74993    +5     
+ Misses      21321    21319    -2     
+ Partials    10797    10794    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanking13 ryanking13 force-pushed the gyeongjae/htmlrewriter-2 branch from 41c35e0 to 4f0e824 Compare January 26, 2026 10:15
@ryanking13 ryanking13 force-pushed the gyeongjae/htmlrewriter-2 branch from 4f0e824 to 57df7e0 Compare February 6, 2026 08:38
@ryanking13 ryanking13 force-pushed the gyeongjae/htmlrewriter-2 branch from 57df7e0 to d386d66 Compare February 6, 2026 08:40
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2026

Merging this PR will improve performance by ×41

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
nullBodyWithStatus[Response] 410.2 µs 10.1 µs ×41

Comparing gyeongjae/htmlrewriter-2 (d386d66) with main (7b9462c)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants