Merged
Conversation
This flag changes the Worker RPC behavior to match Cap'n Web: When a stub is passed in the params of an RPC method, we should NOT transfer ownership of the stub. Instead, the stub is dup()ed. The comments explain in more detail why these semantics are superior (and thus why Cap'n Web took them). Additionally, in the case that the params contain an `RpcTarget`, if that target has a `dup()` method, we call it. This specifically fixes an interoperability bug with Cap'n Web: cloudflare/capnweb#110
kentonv
force-pushed
the
kenton/rpc_params_dup_stubs
branch
from
04d4c78 to
d05081b
Compare
jasnell
approved these changes
Dec 20, 2025
kentonv
added a commit
to cloudflare/capnweb
that referenced
this pull request
Dec 23, 2025
This matches behavior introduced in workerd in: cloudflare/workerd#5733 This plus the workerd change together should allow full end-to-end proxying between Cap'n Web and native workerd RPC to work correctly (provided workerd has enabled the `rpc_params_dup_stubs` compat flag, at least).
kentonv
added a commit
to cloudflare/capnweb
that referenced
this pull request
Dec 23, 2025
This matches behavior introduced in workerd in: cloudflare/workerd#5733 This plus the workerd change together should allow full end-to-end proxying between Cap'n Web and native workerd RPC to work correctly (provided workerd has enabled the `rpc_params_dup_stubs` compat flag, at least).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag changes the Worker RPC behavior to match Cap'n Web: When a stub is passed in the params of an RPC method, we should NOT transfer ownership of the stub. Instead, the stub is dup()ed.
The comments explain in more detail why these semantics are superior (and thus why Cap'n Web took them).
Additionally, in the case that the params contain an
RpcTarget, if that target has adup()method, we call it. This specifically fixes an interoperability bug with Cap'n Web: cloudflare/capnweb#110