Fix TextEncoderStream surrogate pair handling across chunks #5680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Dec 11, 2025
jasnell
reviewed
Dec 11, 2025
jasnell
reviewed
Dec 11, 2025
anonrig
force-pushed
the
yagiz/streams-utf8-wpt
branch
2 times, most recently
from
f80b87b to
f2f10c4
Compare
jasnell
reviewed
Dec 11, 2025
jasnell
reviewed
Dec 11, 2025
jasnell
reviewed
Dec 11, 2025
jasnell
reviewed
Dec 11, 2025
jasnell
reviewed
Dec 11, 2025
erikcorry
reviewed
Dec 12, 2025
anonrig
force-pushed
the
yagiz/streams-utf8-wpt
branch
3 times, most recently
from
508506e to
99423c5
Compare
erikcorry
approved these changes
Dec 16, 2025
Contributor
erikcorry
left a comment
erikcorry
left a comment
There was a problem hiding this comment.
LGTM, FWIW since it now has my code in it too :-)
jasnell
approved these changes
Dec 16, 2025
anonrig
force-pushed
the
yagiz/streams-utf8-wpt
branch
from
59cc2d9 to
d67061b
Compare
Member
Author
|
Rebased and force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5387
The WPT tests failed because we didn't handle utf-16 surrogate pairs correctly as the spec requires us, across separate chunks. Added a pending state to buffer a trailing high surrogate until the next chunk arrives, then either we pair it with a matching low surrogate or emit replacement character. Tried to use as much as simdutf code possible to make the code more readable and maintainable for people who are not experts in such areas.
Comments are generated by AI