-
Notifications
You must be signed in to change notification settings - Fork 440
chore: move python to bzlmod #5129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The generated output of |
ff6f60e
to
27987cf
Compare
7923d74
to
3c523bb
Compare
@fhanau I can't see why this one is red on internal - it's rebased today, can you give me hints? |
I believe it's failing because the internal build still uses WORKSPACE-based python, so it's tripping up on https://github.com/cloudflare/workerd/pull/5129/files#diff-c44211133c16ec2e8919d59a20a200b01720663667e0a2356e7db1ef2b3a15eb |
It sounds like I'm blocked on making a matching internal change then? The old symbol is no longer available in rules_python after the switch. Can you make a corresponding change along with merging this? |
I'll try – maybe there's a way to define an alias and avoid downstream changes, but doing the same kind of change won't be hard either. |
Made a downstream PR |
No description provided.